Skip to content

Refurbish indexerconfig #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 177 commits into from
Oct 30, 2025
Merged

Refurbish indexerconfig #571

merged 177 commits into from
Oct 30, 2025

Conversation

@ala-mode
Copy link
Contributor

@ala-mode ala-mode commented Sep 22, 2025 •
edited
Loading

fixes #500 #506 relevant. #502 and #505 maybe also be partially solved.

@zancas zancas requested a review from pacu September 23, 2025 21:12
@zancas
Copy link
Member

zancas commented Sep 23, 2025

Hey! I really like the way this is looking.. anything that simplifies zaino-testutils is probably very worthwhile.

@ala-mode
Copy link
Contributor Author

ala-mode commented Sep 24, 2025 •
edited
Loading

@pacu or anyone else; this is currently a WIP.

One architecture decision (to put a gRPC related module in zaino-common) was my own attempt to fit things in, and I was not sure of.

Discussions around specifics (and a running list of config fields) can be seen at issue #500

@ala-mode
Copy link
Contributor Author

ala-mode commented Sep 28, 2025

@nachog00 mentioned 'stale pr' #467 on issue 500. That one was started easrly August, and last commit was August 25. It's about +10k lines -3k lines.

Mostly because of the size of the stale PR, I'm probably only going to use it for reference if I find myself stuck.

@ala-mode ala-mode mentioned this pull request Oct 25, 2025
Open
10 tasks
@pacu pacu mentioned this pull request Oct 29, 2025
Closed
@zancas
Copy link
Member

zancas commented Oct 30, 2025

I get this failure locally ( I am running against zebrad main...):

thread 'zebrad::check_info::regtest_no_cache' panicked at integration-tests/tests/state_service.rs:249:5:
assertion `left == right` failed
  left: {ConsensusBranchIdHex(ConsensusBranchId(1537743641)): NetworkUpgradeInfo { name: Overwinter, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(1991772603)): NetworkUpgradeInfo { name: Sapling, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(733220448)): NetworkUpgradeInfo { name: Blossom, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(4122551051)): NetworkUpgradeInfo { name: Heartwood, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3925833126)): NetworkUpgradeInfo { name: Canopy, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3268858036)): NetworkUpgradeInfo { name: Nu5, activation_height: Height(2), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3370586197)): NetworkUpgradeInfo { name: Nu6, activation_height: Height(2), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(1307332080)): NetworkUpgradeInfo { name: Nu6_1, activation_height: Height(1000), status: Pending }}
 right: {ConsensusBranchIdHex(ConsensusBranchId(1537743641)): NetworkUpgradeInfo { name: Overwinter, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(1991772603)): NetworkUpgradeInfo { name: Sapling, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(733220448)): NetworkUpgradeInfo { name: Blossom, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(4122551051)): NetworkUpgradeInfo { name: Heartwood, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3925833126)): NetworkUpgradeInfo { name: Canopy, activation_height: Height(1), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3268858036)): NetworkUpgradeInfo { name: Nu5, activation_height: Height(2), status: Active }, ConsensusBranchIdHex(ConsensusBranchId(3370586197)): NetworkUpgradeInfo { name: Nu6, activation_height: Height(2), status: Active }}
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

   Canceling due to test failure
------------
     Summary [  18.378s] 1 test run: 0 passed, 1 failed, 299 skipped
        FAIL [  18.377s] integration-tests::state_service zebrad::check_info::regtest_no_cache
error: test run failed

@zancas
Copy link
Member

zancas commented Oct 30, 2025

The CI fails will persist until this issue is fixed #620.

@zancas zancas merged commit aa40900 into dev Oct 30, 2025
17 of 19 checks passed
@zancas zancas mentioned this pull request Oct 30, 2025
Open
@zancas
Copy link
Member

zancas commented Oct 30, 2025 •
edited
Loading

When I reset my local state to run against the zebrad 2.5.0 (as specified in .env-testing-artifacts) this test passed.

That lead me to conclude that:

(a) the test in CI is working against zebrad 2.5.0
(b) the test does not expect the zebrad it is working against to have NU6.1 support

On the strength of that evidence, and in the context of the zebrad 3.0.0 upgrade which DOES support NU6.1 being imminent, I concluded that the test was correctly passing against the CI-matched zebrad.

That is to say I expected that the test would need to be upgraded with the zebrad 3.0.0 update.

@dorianvp dorianvp deleted the refurbish_indexerconfig branch October 30, 2025 18:31
This was referenced Nov 1, 2025
Closed
Open
@ala-mode ala-mode mentioned this pull request Nov 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zancas zancas zancas approved these changes

@pacu pacu Awaiting requested review from pacu

@nachog00 nachog00 Awaiting requested review from nachog00

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Primitive Obsession - Configuration uses primitive types requiring runtime validation

4 participants

@ala-mode @zancas @nachog00